Skip to content

Delete the "del" flag #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2025
Merged

Delete the "del" flag #1058

merged 3 commits into from
Sep 29, 2025

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Sep 29, 2025

InitContext made it redundant.

Could now change the whole flags structure to not be a dict, but might not be worth it if we could just switch over to VarNamedVector.

@mhauru mhauru changed the base branch from main to breaking September 29, 2025 11:07
@mhauru mhauru closed this Sep 29, 2025
@mhauru mhauru reopened this Sep 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025 •
edited
Loading

Benchmark Report for Commit 1de7fed

Computer Information

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

┌───────────────────────┬───────┬─────────────┬───────────────────┬────────┬────────────────┬─────────────────┐
│                 Model │   Dim │  AD Backend │           VarInfo │ Linked │ t(eval)/t(ref) │ t(grad)/t(eval) │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼────────────────┼─────────────────┤
│ Simple assume observe │     1 │ forwarddiff │             typed │  false │            9.1 │             1.5 │
│           Smorgasbord │   201 │ forwarddiff │             typed │  false │          659.3 │            42.2 │
│           Smorgasbord │   201 │ forwarddiff │ simple_namedtuple │   true │          424.0 │            53.1 │
│           Smorgasbord │   201 │ forwarddiff │           untyped │   true │         1185.6 │            28.6 │
│           Smorgasbord │   201 │ forwarddiff │       simple_dict │   true │         6983.2 │            26.2 │
│           Smorgasbord │   201 │ reversediff │             typed │   true │         1035.5 │            40.4 │
│           Smorgasbord │   201 │    mooncake │             typed │   true │         1021.4 │             4.7 │
│    Loop univariate 1k │  1000 │    mooncake │             typed │   true │         5757.3 │             4.3 │
│       Multivariate 1k │  1000 │    mooncake │             typed │   true │          974.4 │             9.6 │
│   Loop univariate 10k │ 10000 │    mooncake │             typed │   true │        63833.6 │             3.9 │
│      Multivariate 10k │ 10000 │    mooncake │             typed │   true │         8390.3 │            10.7 │
│               Dynamic │    10 │    mooncake │             typed │   true │          137.2 │            11.1 │
│              Submodel │     1 │    mooncake │             typed │   true │           12.4 │             5.1 │
│                   LDA │    12 │ reversediff │             typed │   true │         1031.8 │             2.0 │
└───────────────────────┴───────┴─────────────┴───────────────────┴────────┴────────────────┴─────────────────┘

@codecov Codecov
Copy link

codecov bot commented Sep 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (breaking@7311465). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/varinfo.jl 42.85% 4 Missing ⚠️
src/threadsafe.jl 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             breaking    #1058   +/-   ##
===========================================
  Coverage            ?   82.39%           
===========================================
  Files               ?       41           
  Lines               ?     3799           
  Branches            ?        0           
===========================================
  Hits                ?     3130           
  Misses              ?      669           
  Partials            ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mhauru mhauru requested a review from penelopeysm September 29, 2025 11:52
penelopeysm
penelopeysm approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@penelopeysm penelopeysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though could you add a changelog entry? Feel free to merge afterwards.

@mhauru mhauru merged commit c08cfa5 into breaking Sep 29, 2025
8 of 19 checks passed
@mhauru mhauru deleted the mhauru/delete-del branch September 29, 2025 14:24
@github-actions GitHub Actions
Copy link
Contributor

DynamicPPL.jl documentation for PR #1058 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR1058/

@mhauru mhauru mentioned this pull request Sep 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penelopeysm penelopeysm penelopeysm approved these changes

Assignees

@mhauru mhauru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhauru @penelopeysm